Skip to content
This repository has been archived by the owner on Nov 17, 2022. It is now read-only.

Use photon colors consistently #383

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ariasuni
Copy link
Contributor

Also fix about:addons icon not colored correctly in dark theme and improve a bit new tab button margin and centering.

@Keith94
Copy link

Keith94 commented Sep 20, 2018

Hey @ariasuni
I found an issue with our icon using the wrong colors. If you have time, check it out. 😃

image

@ariasuni
Copy link
Contributor Author

This bug is already present in the current version of the extension and it seems it can’t be easily fixed programmatically. The icon displayed in the header bar and in the list is the same, but with the default dark theme of Firefox, one’s white and the other dark, and we can’t really know what’s the currently used color for each.

The best fix I can see is to make an icon that works both on light and dark backgrounds, but’s that’s not the in the scope of this PR. Would you mind opening another issue for that? I’ll then copy/paste my comment there.

@Keith94
Copy link

Keith94 commented Sep 27, 2018

Thanks. Here it is: #392

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants