Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch:lib] Remove key-word arguments from Paper#id and Paper#url #70

Merged
merged 1 commit into from
May 3, 2019

Conversation

eonu
Copy link
Owner

@eonu eonu commented May 3, 2019

  • Remove key-word arguments from Paper#id and Paper#url.

    Previously, Paper#id and Paper#url accepted a version key-word argument, which was a boolean variable indicating whether or not to include the version number in the ID or URL.

    This has now been changed to a regular argument, which still defaults to false.

    paper = Arx.get('cond-mat/9609089')
    
    # Old (no longer works)
    paper.id(version: true)
    paper.url(version: true)
    
    # New
    paper.id(true) #=> "cond-mat/9609089v1"
    paper.url(true) #=> "http://arxiv.org/abs/cond-mat/9609089v1"

@eonu eonu merged commit 0e7fe75 into master May 3, 2019
@eonu eonu deleted the patch/paper-kwargs branch May 3, 2019 17:55
@eonu eonu mentioned this pull request May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant