Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch:lib] Update Arx() to match new Arx.search signature #94

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

eonu
Copy link
Owner

@eonu eonu commented Apr 16, 2021

Checklist

  • All old and new tests pass (ran bundle exec rspec spec in the root directory).
  • Read the contribution guidelines.
  • Updated documentation (if necessary).

Reason (or issue)

#92 forgot to apply the new start and max_results keyword arguments in Arx.search to the Arx() function.

This raises the question as to whether we really need both Arx.search (and its alias Arx.get) and Arx.

Description

Adds the new keyword arguments to the Arx() function.

@eonu eonu changed the title [patch:lib] Update top-level function to match new Arx.search signature [patch:lib] Update Arx() to match new Arx.search signature Apr 16, 2021
@eonu eonu merged commit 4378469 into master Apr 16, 2021
@eonu eonu deleted the patch/top-level branch April 16, 2021 22:23
@eonu eonu mentioned this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant