Fixed bad handling of core symbol #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core symbol is now retrieved on-demand when a command requires it. The current retrieval way is to query the `rammarket` table which should have a row only when `eosio:init` has been called with the core symbol set. This row has a quote balance asset value that is always equalt to the core symbol. This is where we get it. In the eventuality that it's not possible to retrieve, the user can still override the default 4,EOS by passing `--core-symbol` to the `eosc` CLI. This will use this core symbol only when impossible to infer it. Also added logging facilities to help debugging certain part of the `eosc` CLI. Fixes #136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core symbol is now retrieved on-demand when a command requires it. The current retrieval way is to query the
rammarkettable which should have a row only wheneosio:inithas been called with the core symbol set.This row has a quote balance asset value that is always equalt to the core symbol. This is where we get it.
In the eventuality that it's not possible to retrieve, the user can still override the default 4,EOS by passing
--core-symbolto theeoscCLI. This will use this core symbol only when impossible to infer it.Also added logging facilities to help debugging certain part of the
eoscCLI.Fixes #136