Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REX support for no-EOS core symbol #136

Closed
DenisCarriere opened this issue May 27, 2019 · 3 comments · Fixed by #141
Closed

REX support for no-EOS core symbol #136

DenisCarriere opened this issue May 27, 2019 · 3 comments · Fixed by #141

Comments

@DenisCarriere
Copy link

The eosc rex feature does not work for networks such as BOS that doesn't use EOS symbol.

$ eosc -u https://bos.eosn.io rex deposit <ACCOUNT> "1.0000 BOS" 
ERROR: invalid 4,EOS asset for "quantity": EOS has max 4 decimals
maoueh pushed a commit that referenced this issue Jun 14, 2019
Fixed bad handling of core symbol
1a909be 
The core symbol is now retrieved on-demand when a command requires it. The
current retrieval way is to query the `rammarket` table which should have
a row only when `eosio:init` has been called with the core symbol set.

This row has a quote balance asset value that is always equalt to the
core symbol. This is where we get it.

In the eventuality that it's not possible to retrieve, the user can still
override the default 4,EOS by passing `--core-symbol` to the `eosc` CLI.
This will use this core symbol only when impossible to infer it.

Also added logging facilities to help debugging certain part of the `eosc`
CLI.

Fixes #136
@maoueh maoueh mentioned this issue Jun 14, 2019
Merged
@DenisCarriere
Copy link
Author

Woohoo 🎉

@maoueh
Copy link
Contributor

maoueh commented Jun 20, 2019

Note that by being on the right chain, it will infer the core symbol automatically. So:

eosc -u https://bos.eosn.io rex deposit <ACCOUNT> 1

Will now work as expected, normally.

@DenisCarriere
Copy link
Author

👍 yea, that's expected

Looking forward to check out this improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bad handling of core symbol eoscanada/eosc
2 participants
@maoueh @DenisCarriere