Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit input transaction dedup time #45

Merged
merged 1 commit into from
Mar 12, 2022
Merged

Limit input transaction dedup time #45

merged 1 commit into from
Mar 12, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Feb 26, 2022

  • Respect the cpu-effort-percent while removing expired transactions from deduplication list.

@swatanabe
Copy link
Contributor

I'm pretty sure that extra expired transaction_objects do not affect consensus. Have you fully verified this?

If the timer expires, it will result in an empty block, right?

@heifner
Copy link
Member Author

heifner commented Feb 28, 2022

Yes, an empty block if timer expires, similar to if it expires in the other steps of the producer_plugin start_block.
As for consensus, I was also a bit worried, but these are input transactions that have succeeded. Extra transactions in the list would result in a duplicate transaction exception instead of an expired transaction (actually expired is checked before duplication check). Since either would only be during building of a block it should not affect consensus.

Copy link
Contributor

@swatanabe swatanabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just to confirm, this is not a backport of changes to EOSIO and there is no conversation elsewhere that needs to be referenced?

@heifner
Copy link
Member Author

heifner commented Feb 28, 2022

This is not a backport, although EOSIO/eos could certainly use this change. I should push it up there as well.
The conversation was with Wax BPs on telegram.

@heifner
Copy link
Member Author

heifner commented Feb 28, 2022

A bit of more info about this. WAX was seeing BPs taking more than cpu-effort-percent time in removing duplicate transactions. Upgrading to EOSIO/eos 2.1.x with your improved chainbase fixed the problem for them. Since Mandel also has the newer chainbase presumably that would also fix their issue.

@heifner
Copy link
Member Author

heifner commented Feb 28, 2022

EOSIO/eos#11071

@heifner heifner merged commit 64c7f61 into main Mar 12, 2022
@heifner heifner deleted the limit-dedup branch March 12, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants