-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Replace websocketpp with boost beast #675
Conversation
http_plugin boost::beast migration, keep-alive (EPE-9 / GH-3678)
#148 indicated that this could be possibly improved. That very well may be the case, but this is, I believe, a good improvement to the existing http implementation. I would recommend we bring this in and make any enhancements as a separate task @spoonincode. |
The code is seemingly over verbose and/or bloated. It doesn't need to be 'enhanced' but instead simplified, but I don't see that ever happening once it's merged in as is, which is why I originally indicated to have a discussion on it before blindly taking it. |
A couple low effort comments from starting to get in to this again:
// Start accepting incoming connections
void start_accept()
{
if(!is_listening_) return;
do_accept();
}
bool is_listening() {
return is_listening_;
} I'm not sure if maybe we should run this through a clang-format fixup? |
That seems reasonable because I agree the code does seem to not follow a single convention. Do you have a preferred style (LLVM, Google, Chromium, Mozilla, WebKit, Microsoft) you would like me to use? |
We have talked about this for years. What about just going with a .clang-format, I don't particularly care the exact style. Here is one from CLion that I think closely matches what we use in most files:
|
Closing due to migration to leap AntelopeIO/leap#22 |
Resolves #148