Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save to CDX converts plus and arrow into lone pair and line #1773

Closed
AlexeyGirin opened this issue Mar 4, 2024 · 2 comments · Fixed by #1841, #1842, #1887 or #1888
Closed

Save to CDX converts plus and arrow into lone pair and line #1773

AlexeyGirin opened this issue Mar 4, 2024 · 2 comments · Fixed by #1841, #1842, #1887 or #1888
Assignees
@AliaksandrDziarkach
Labels
Bug Priority: High
Milestone
Indigo-1.19.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Mar 4, 2024 •
edited

Describe the bug
Save to CDX converts plus into lone pair

Steps to Reproduce

  1. Put on the canvas following SMILE: [HH].O>>O
  2. Save to CDX format file
  3. Open it in ChemDraw (ver 15 in my case)

Actual behavior
System converts plus and arrow into lone pair and line
image

Expected behavior
Plus and arrow remain unchanged
image

Environment details (please complete the following information):

  • Indigo Toolkit Version 1.18.0-rc.9.0-gc7efb4e71-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.18.0-rc9 Build at 2024-02-27; 16:16:47
  • Chrome Version 122.0.6261.70 (Official Build) (64-bit)
  • Win10
@AlexeyGirin AlexeyGirin added this to the Indigo-1.19.0-rc.1 milestone Mar 4, 2024
@AlexeyGirin AlexeyGirin added this to Product Backlog in Indigo via automation Mar 4, 2024
@AlexanderSavelyev AlexanderSavelyev removed this from Product Backlog in Indigo Mar 6, 2024
AliaksandrDziarkach added a commit that referenced this issue Mar 18, 2024
@AliaksandrDziarkach
#1773 Save to CDX converts plus and arrow into lone pair and line
4bc6c84 
Add code to save ArrowHeadType and Symbol type. Fix UTs
This was linked to pull requests Mar 18, 2024
#1773 Save to CDX converts plus and arrow into lone pair and line #1841
Merged
Backmerge: #1773 Save to CDX converts plus and arrow into lone pair and line #1842
Merged
AlexanderSavelyev pushed a commit that referenced this issue Mar 19, 2024
@AliaksandrDziarkach
#1773 Save to CDX converts plus and arrow into lone pair and line (#1841
c5cfae8 
)
AlexanderSavelyev pushed a commit that referenced this issue Mar 19, 2024
@AliaksandrDziarkach
Backmerge: #1773 Save to CDX converts plus and arrow into lone pair a…
b7ff149 
…nd line (#1842)
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Mar 28, 2024 •
edited

Not fully fixed.
image
System now loads "+" instead of ":" - this is good (to be correct - if we past same smile to ChemDraw - it uses different plus, but this is acceptable)
As for the arrow - it shown as plain line, not arrow.
Please make it arrow to make it look close to the reference
image

  • Indigo Toolkit Version 1.19.0-rc.2.0-g6c0e3fecf-x86_64-linux-gnu-11.2.1
  • Ketcher Version 2.20.0-rc2 Build at 2024-03-27; 08:30:51
  • Chrome Version 122.0.6261.70 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin reopened this Mar 28, 2024
AliaksandrDziarkach added a commit that referenced this issue Mar 29, 2024
@AliaksandrDziarkach
#1773 Save to CDX converts plus and arrow into lone pair and line
e7115ea 
Fix kCDXProp_Arrow_ArrowHead values. Fix UTs
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Mar 29, 2024 that will close this issue
#1773 Save to CDX converts plus and arrow into lone pair and line #1887
Merged
8 tasks
AliaksandrDziarkach added a commit that referenced this issue Mar 29, 2024
@AliaksandrDziarkach
Backmerge: #1773 Save to CDX converts plus and arrow into lone pair a…
8edcdb9 
…nd line

Fix kCDXProp_Arrow_ArrowHead values. Fix UTs
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Mar 29, 2024 that will close this issue
Backmerge: #1773 Save to CDX converts plus and arrow into lone pair and line #1888
Merged
4 tasks
AliaksandrDziarkach added a commit that referenced this issue Mar 29, 2024
@AliaksandrDziarkach
#1773 Save to CDX converts plus and arrow into lone pair and line (#…
71caf0f 
…1887)
AliaksandrDziarkach added a commit that referenced this issue Mar 31, 2024
@AliaksandrDziarkach
Backmerge: #1773 Save to CDX converts plus and arrow into lone pair a…
a704745 
…nd line (#1888)
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Indigo Toolkit Version 1.19.0-rc.3.0-gf2d7689b-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.20.0-rc2 Build at 2024-04-04; 11:31:49
  • Chrome Version 122.0.6261.70 (Official Build) (64-bit)
  • Win10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AliaksandrDziarkach AliaksandrDziarkach

Labels
Bug Priority: High
Projects
None yet
Milestone
Indigo-1.19.0-rc.3
3 participants
@even1024 @AliaksandrDziarkach @AlexeyGirin