Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad performance during the parsing of large sequences #1802

Closed
even1024 opened this issue Mar 12, 2024 · 5 comments · Fixed by #1845, #1860 or #1934
Closed

bad performance during the parsing of large sequences #1802

even1024 opened this issue Mar 12, 2024 · 5 comments · Fixed by #1845, #1860 or #1934
Assignees
@even1024
Labels
Improvement Performance Bucket: Performance related issues
Milestone
Indigo-1.20.0-rc.2

Comments

@even1024
Copy link
Collaborator

Steps to Reproduce

  1. Use JS which loads huge multiple RNA/DNA sequences
  2. Make benchmark measurements

Actual behaviour
Parsing takes too long time

Expected behavior
It should work much faster
@even1024 even1024 added this to the Indigo-1.19.0-rc.1 milestone Mar 12, 2024
@even1024 even1024 self-assigned this Mar 12, 2024
@even1024 even1024 linked a pull request Mar 19, 2024 that will close this issue
#1802 bad performance in WASM during the parsing of large sequences #1845
Merged
8 tasks
@AlexeyGirin
Copy link
Collaborator

Move to 1.20 since that is tech task

even1024 added a commit that referenced this issue Mar 21, 2024
@even1024
#1802 bad performance in WASM during the parsing of large sequences (#…
1fd7103 
…1845)
even1024 added a commit that referenced this issue Mar 21, 2024
@even1024
#1802 bad performance in WASM during the parsing of large sequences (#…
03524f6 
…1845)
@even1024 even1024 linked a pull request Mar 21, 2024 that will close this issue
Backmerge: #1802 bad performance in WASM during the parsing of large sequences #1860
Merged
4 tasks
even1024 added a commit that referenced this issue Mar 21, 2024
@even1024
Backmerge: #1802 bad performance in WASM during the parsing of large …
cb4aef0 
…sequences (#1860)
@AlexeyGirin
Copy link
Collaborator

Question to @rrodionov91 - what operation was slow in particular

@AlexeyGirin
Copy link
Collaborator

MOved to rc3 since it is not clear what to check

@AlexeyGirin AlexeyGirin changed the title bad performance in WASM during the parsing of large sequences bad performance during the parsing of large sequences Apr 3, 2024
@AlexeyGirin AlexeyGirin reopened this Apr 18, 2024
@AlexeyGirin
Copy link
Collaborator

Roman found extra room for improvement

@AlexeyGirin AlexeyGirin added the Performance Bucket: Performance related issues label Apr 18, 2024
@even1024 even1024 linked a pull request Apr 29, 2024 that will close this issue
#1802 - bad performance during the parsing of large sequences #1934
Merged
7 tasks
AlexanderSavelyev pushed a commit that referenced this issue Apr 29, 2024
@even1024
#1802 - bad performance during the parsing of large sequences (#1934)
fde8eaa
even1024 added a commit that referenced this issue May 2, 2024
@even1024
#1802 - bad performance during the parsing of large sequences (#1934)
e7605aa
AlexanderSavelyev pushed a commit that referenced this issue May 3, 2024
@even1024
Backmerge: #1802 - bad performance during the parsing of large sequen…
ed69e8e 
…ces (#1934) (#1940)
@AlexeyGirin
Copy link
Collaborator

Works reasonably fast with 6000 peptide chain.
Verified.

  • Windows 10
  • Chrome Version Version 124.0.6367.119 (Official Build) (64-bit)
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-07; 12:32:44
  • Indigo Toolkit Version 1.20.0-rc.2.0-g111a89f35-wasm32-wasm-clang-12.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Improvement Performance Bucket: Performance related issues
Projects
None yet
Milestone
Indigo-1.20.0-rc.2
2 participants
@even1024 @AlexeyGirin