Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ObjArray with std::vector #815

Open
AStepaniuk opened this issue Aug 4, 2022 · 0 comments
Open

Replace ObjArray with std::vector #815

AStepaniuk opened this issue Aug 4, 2022 · 0 comments
Assignees

Comments

@AStepaniuk
Copy link
Collaborator

ObjArray is an object-wise wrapper around Array.
Though ObjArray is still not safe to use with C++ objects because underlying Array does not properly copies/moves objects on buffer re-allocation.

A simple solution here: replace ObjArray with std::vector, which has pretty similar interface and correctly deals with contained objects.
Challenges:

  1. The contained type needs to have move constructor, marked as noexcept
  2. ObjArray can qsort() items using its own method. This method needs to be extracted as a standalone function, implemented as an algorithm
@AStepaniuk AStepaniuk self-assigned this Aug 4, 2022
AStepaniuk pushed a commit that referenced this issue Aug 5, 2022
AStepaniuk pushed a commit that referenced this issue Aug 5, 2022
Partial implementatiom: ReactionSubMatcher is updated.
AStepaniuk pushed a commit that referenced this issue Aug 10, 2022
ObjArray is removed from PropertiesMap class. std classes are used instead.
AStepaniuk pushed a commit that referenced this issue Aug 10, 2022
AStepaniuk pushed a commit that referenced this issue Sep 14, 2022
IndigoDeconvolution update
AStepaniuk pushed a commit that referenced this issue Sep 15, 2022
AStepaniuk pushed a commit that referenced this issue Sep 15, 2022
AStepaniuk pushed a commit that referenced this issue Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant