api: dotnet: expose oneBitsList #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MysterionRise
approved these changes
Feb 16, 2021
mkviatkovskii
approved these changes
Feb 16, 2021
SunFellow
reviewed
Feb 16, 2021
| @@ -1694,6 +1694,11 @@ public string check2(string type) | |||
| return dispatcher.checkResult(IndigoLib.indigoCheckObj2(self, type)); | |||
| } | |||
|
|
|||
| public IndigoObject fingerprint() | |||
There was a problem hiding this comment.
Do we have real demand for such method (except in test, where no problem to pass null)?
SunFellow
reviewed
Feb 16, 2021
| Assert.AreEqual( | ||
| "1698 1719 1749 1806 1909 1914 1971 2056", | ||
| indigoObject.fingerprint().oneBitsList(), | ||
| "same one bits as in string 1698 1719 1749 1806 1909 1914 1971 205"); |
There was a problem hiding this comment.
Why missed the last 6 in the string? (205 instead 2056)
Here and in the referred Java pull request (apparently copy-pasted).
There was a problem hiding this comment.
Yes, my bad.
Imho this data shouldn't be mentioned in the message parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oneBitsList was not mapped in dotnet
related java issue: #191
ps: also added necessary gitignore patterns for dotnet tools