Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend and improve integration tests #33

Closed
kamyshova opened this issue Jan 20, 2020 · 0 comments
Closed

Extend and improve integration tests #33

kamyshova opened this issue Jan 20, 2020 · 0 comments
Labels
sprint4

Comments

@kamyshova
Copy link
Collaborator

kamyshova commented Jan 20, 2020 •
edited
Loading

Background

The existing integration tests don't completely cover all the workflow logic and have code style shortcomings.

Approach

The existing integration tests can be extended and improved with Thymeleaf Template Engine.

  • rewrite the existing test cases with thymeleaf template
  • add a new test cases to extend covered logic
  • add a folder tree validation
  • use JUnit 5 instead of JUnit 4
@kamyshova kamyshova added the good first issue Good for newcomers label Jan 20, 2020
This was referenced Jan 22, 2020
Closed
Closed
@kamyshova kamyshova removed the good first issue Good for newcomers label Jan 22, 2020
This was referenced Jan 29, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@kamyshova kamyshova mentioned this issue Feb 17, 2020
Closed
DTegai pushed a commit that referenced this issue Feb 21, 2020
issue #33: clean up integration tests, delete unused dependencies
576a1d1
@DTegai DTegai mentioned this issue Feb 21, 2020
Merged
DTegai pushed a commit that referenced this issue Feb 21, 2020
issue #33: delete unused variable
0d1011b
DTegai pushed a commit that referenced this issue Feb 21, 2020
issue #33: replace templates
dd1d6db
kamyshova added a commit that referenced this issue Feb 21, 2020
@kamyshova
Issue #33: small refactoring
5cc753a
kamyshova pushed a commit that referenced this issue Feb 25, 2020
@DTegai
Issue #33: Extend and improve integration tests (#83)
cbc4393 
* issue #33: clean up integration tests, delete unused dependencies
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sprint4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kamyshova @DTegai