Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro: UI support for IDT import/export #4495

Closed
olganaz opened this issue Apr 18, 2024 · 3 comments · Fixed by #4549
Closed

Macro: UI support for IDT import/export #4495

olganaz opened this issue Apr 18, 2024 · 3 comments · Fixed by #4549
Assignees
Labels
feature request Test Cases Written Test cases has been written for that issue
Projects

Comments

@olganaz
Copy link
Collaborator

olganaz commented Apr 18, 2024

Requirements

Open

Add option "IDT" to the format dropdown menu of modal window 'Open'/'Paste from the clipboard'

Save As

Add option "IDT" to dropdown 'File format' of modal window 'Save Structure'

In case of peptide monomers are on canvas, error "Peptide monomers are not supported in IDT" should appear >>

According to latest BA solution error message was changed before implementation:
We should have message for CHEM, Peptides and RNA if they are not in IDT library:
"Cannot save molecule in IDT format - monomer(s)… doesn’t have IDT code."

Backend part:

@olganaz olganaz added this to the Ketcher 2.22.0-rc.1 milestone Apr 18, 2024
@olganaz olganaz changed the title Macro: UI support for import/export IDT Macro: UI support for IDT import/export Apr 18, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this Apr 23, 2024
@Zhirnoff
Copy link
Collaborator

Tests added to the automation table.

@ilya-asiyuk-epam ilya-asiyuk-epam added this to In progress in Ketcher Apr 29, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam linked a pull request Apr 29, 2024 that will close this issue
9 tasks
@ilya-asiyuk-epam ilya-asiyuk-epam moved this from In progress to Code review in Ketcher Apr 29, 2024
ilya-asiyuk-epam added a commit that referenced this issue Apr 29, 2024
…rt-export

#4495 - Macro: UI support for IDT import/export
Ketcher automation moved this from Code review to Ready for testing Apr 29, 2024
@AlexeyGirin AlexeyGirin added the Test Cases Written Test cases has been written for that issue label May 8, 2024
@NadezhdaPeskun
Copy link
Collaborator

NadezhdaPeskun commented May 13, 2024

We can save as IDT format, but we cannot open it or open it from the clipboard:
a)
rUrA
rUrA

Image

b)
/52MOErA//i2MOErC//32MOErT/
/5Phos/ACG/3Phos/

c)
rA/3Phos/

d)
rA/3Phos/
rU/3Phos/

Image

Image

image

@AlexeyGirin
Copy link
Collaborator

Verified.

image
image

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Test Cases Written Test cases has been written for that issue
Projects
Ketcher
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants