Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option in settings - "ACS Style" #5156

Open
ljubica-milovic opened this issue Jul 23, 2024 · 1 comment
Open

Add new option in settings - "ACS Style" #5156

ljubica-milovic opened this issue Jul 23, 2024 · 1 comment

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 23, 2024

Background
Just introducing all necessary settings that are needed to comply with ACS style is not enough. We should introduce a user-friendly way for the user to select ACS style.
A new section in the settings "ACS Style" should be added for that purpose.

Requirements

  1. A new option in setting should be added called "ACS Style"
    1.1. The section should be placed above "Reset to Select Tool" setting in "General"
    1.2. The user can turn the option "ON" or "OFF"
    1.3. Existing toggle UX should be reused.
    (image for better understanding)
    image
    1.4. By default (and upon settings "Reset") the option is disabled.

  2. When the user clicks on the toggle a warning message appears: "Selecting ACS Style will change value of certain settings and make them read-only. Do you wish to continue?"
    2.1. "Yes" - warning window is closed, the toggle is ON.
    2.2. "Cancel" - warning window is closed, the toggle is OFF.
    2.3. The default option is "Cancel".

  3. If "ACS Style" gets turned ON (just toggle on ON) certain default values and units of measurement for following settings are chosen, and these settings are disabled:

Setting Setting position "ACS Style" Unit of Measurement
Atom coloring General OFF
Font General Arial
Font size General 10 pt
Sub font size General 10 pt
Margin size (new setting) General 1,6 pt
Image resolution (new setting) General 600 ppi
Bond length (new setting) Bonds 14,4 pt
Bond spacing (old name: Double bond width) Bonds 18 % of width
Bond thickness Bonds 0,6 pt
Stereo (Wedge) bond width Bonds 2 pt
Hash spacing (new setting) Bonds 2,5 pt
  1. When "ACS Style" is turned ON (toggle on ON -> Apply at the bottom of the window), positions of all elements on the canvas are recalculated so that they comply with "ACS Style".

  2. If "ACS Style" is turned OFF (just toggle on OFF) after it was ON, previously disabled settings are not disabled anymore.

  3. A new field "isACSStyle": false is added to the JSON for the Settings

UX
TBD

@AnnaKosol AnnaKosol added Team G Test Cases Written Test cases has been written for that issue and removed Test Cases Written Test cases has been written for that issue labels Jul 25, 2024
@AnnaKosol AnnaKosol added the Test Cases Written Test cases has been written for that issue label Jul 26, 2024
@AnnaKosol
Copy link
Collaborator

To solve this task, it is necessary to implement #5175 and #5176

@AnnaKosol AnnaKosol removed the Test Cases Written Test cases has been written for that issue label Aug 1, 2024
@ljubica-milovic ljubica-milovic changed the title Add new section in settings - "Visual representation" Add new option in settings - "Visual representation" Aug 1, 2024
@ljubica-milovic ljubica-milovic changed the title Add new option in settings - "Visual representation" Add new option in settings - "ACS Style" Aug 1, 2024
@AnnaKosol AnnaKosol added the Test Cases Written Test cases has been written for that issue label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants