Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme prop support to viewer component #387

Closed
AnaMoskvina opened this issue Jan 19, 2022 · 0 comments · Fixed by #390
Closed

Add theme prop support to viewer component #387

AnaMoskvina opened this issue Jan 19, 2022 · 0 comments · Fixed by #390
Assignees
@AnaMoskvina
Labels
technical debt
Milestone
Release 0.10.0

Comments

@AnaMoskvina
Copy link

  • consider applying provider pattern
  • update custom theme interface
@AnaMoskvina AnaMoskvina added this to the Release 0.10.0 milestone Jan 19, 2022
@AnaMoskvina AnaMoskvina self-assigned this Jan 19, 2022
@AnaMoskvina AnaMoskvina linked a pull request Jan 20, 2022 that will close this issue
#387 add theme prop support to viewer component #390
Merged
AndreiMazol pushed a commit that referenced this issue Jan 21, 2022
@AnaMoskvina
#387 add theme prop support to viewer component (#390)
5ffad67 
* add support of theme prop, update types

* return deleted files

* update typings

* move DeepPartial type into viewer

Co-authored-by: Anastasiia Moskvina <anastasiia_moskvina@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaMoskvina AnaMoskvina

Labels
technical debt
Projects
Miew
Status: Done
Milestone
Release 0.10.0
Development

Successfully merging a pull request may close this issue.

#387 add theme prop support to viewer component epam/miew
1 participant
@AnaMoskvina