Added ports to the scatter and enable usage of variables into the scatter #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidest
approved these changes
May 15, 2017
| if (!(config instanceof Action)) { | ||
| config.canHavePorts = false; | ||
| } else { | ||
| if (config instanceof Action) { |
There was a problem hiding this comment.
Do we still unable to create groups from actions?
There was a problem hiding this comment.
@voidest currently it looks like there are no sense to create groups from actions. Let me leave it for a while.
test/model/GroupTest.js
Outdated
| @@ -37,7 +37,7 @@ describe('model/Group', () => { | |||
| }); | |||
|
|
|||
| it('throws error when try to create with ports', () => { | |||
There was a problem hiding this comment.
Should we rename/remove this test?
There was a problem hiding this comment.
Thank you for the notisance!
I will correct the name of this test
sidoruka
force-pushed
the
feature/step-inputs
branch
from
5bf2819
to
81ba15a
Compare
sidoruka
approved these changes
May 18, 2017
This was referenced May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General idea
Since PR#20 was been merged it become possible to have a connections and ports in the scatter (if/while). This possibility make us able to propose solution for the following issues: #9 , #11 , #15 , and rewrite temporary fix for #16 , #21 . Currently pipeline-builder does not support the inputs in scatter(if/while) and does not show the scatter iteration item as a port. This pull request implements this features and hopefully fixes some bugs ( #15 , #16 , #21 ).
In this PR it will look like:
Changes
Scripts affected