Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deviating shift participation times #570

Merged
merged 36 commits into from
Nov 26, 2021
Merged

Deviating shift participation times #570

merged 36 commits into from
Nov 26, 2021

Conversation

felixrindt
Copy link
Member

@felixrindt felixrindt commented Oct 3, 2021

Fixes #66. Fixes #524.

functionality

  • model
  • signup logic & form
  • changing the time after signing up
  • refactor signup configuration to use a dedicated form class
  • dispatch form
  • disallow deviating shift times
  • make sure confirmed participations are not set back to required if only e.g. the comment changed
  • Fix code TODOs
  • Fix github comments
  • Implement/discard comments on Allow participation times to deviate from shift times #66
    • esp. check that I can register with deviating time if the default time would be blocked by conflicting participations

fixing other places

  • collision detection
  • working hours count
  • integrate into section based signup view
  • check behavior with coupled signup, disallow deviation or don't copy rendering

user-informative changes

  • update inline participation card
  • event detail page
  • update ical export
  • update index page
  • trigger notifications for changed times for confirmed participations
  • update notification text

Move to issue when closing the PR

UX
  • make the signup form UX nicer -> Improve Participation Form UX #617
    • maybe have a nicer widget that puts the date in a less important position
      • actually automatically determining the date might be the best solution. We just pick the date so the resulting datetime is closest to the initial value.
      • hide disabled widgets in signup view or explain that they are disabled.
  • can we do better in form validation as suggested in the bootstrap docs? I don't think we should be moving all validation to the client side, but we could migrate the vanilla JS validation to be styled bootstrappy! -> Bootstrappy Form Validation #618
refactoring

-> #619

  • move PDF export functionality to PDF exporter class
  • consider refactoring Mixin based composition of signup methods (e.g. mixing Sections and Approval workflows)
Consequences for participant participation manipulation

This is probably very low priority, but we could build consequences to alter participation state. Although we would probably want to display them in the disposition view etc. -> #620

@coveralls
Copy link

coveralls commented Oct 3, 2021

Coverage Status

Coverage increased (+0.2%) to 91.237% when pulling a7b0e33 on varying-shift-times into b76a7a9 on main.

@felixrindt felixrindt force-pushed the varying-shift-times branch 5 times, most recently from 8826d6d to 6cfd0d6 Compare October 10, 2021 21:15
@felixrindt felixrindt force-pushed the varying-shift-times branch 3 times, most recently from c4bce24 to 71aa47a Compare October 27, 2021 23:13
@felixrindt felixrindt force-pushed the varying-shift-times branch 2 times, most recently from a0aeb5a to dcd85c3 Compare October 28, 2021 09:31
@felixrindt felixrindt force-pushed the varying-shift-times branch 7 times, most recently from 1181a6c to 68aecd9 Compare November 8, 2021 22:55
@felixrindt felixrindt marked this pull request as ready for review November 8, 2021 22:55
@felixrindt felixrindt force-pushed the varying-shift-times branch 2 times, most recently from 8cf896d to 62d946e Compare November 8, 2021 23:05
@felixrindt felixrindt force-pushed the varying-shift-times branch 4 times, most recently from 72c55d1 to 8651cea Compare November 20, 2021 19:13
@felixrindt felixrindt merged commit 8f1e0d5 into main Nov 26, 2021
@felixrindt felixrindt deleted the varying-shift-times branch November 26, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants