Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1105 - improve json logs for post processing #1114

Merged
merged 9 commits into from
Apr 27, 2024

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Mar 30, 2024

Landing a Pull Request (PR)

closes #1097
closes #1105
closes #1118
closes #1122

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (f3d6d18) to head (4f53f4f).

❗ Current head 4f53f4f differs from pull request most recent head 0c2742a. Consider uploading reports for the commit 0c2742a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
- Coverage   92.55%   92.52%   -0.04%     
==========================================
  Files          63       58       -5     
  Lines       12352    12086     -266     
==========================================
- Hits        11433    11182     -251     
+ Misses        919      904      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epi052 epi052 merged commit 8eb41f4 into main Apr 27, 2024
12 of 14 checks passed
@epi052 epi052 deleted the 1105-json-host-stats-correlation branch April 27, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant