Bump leaky-bucket to 0.12.1 #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ayyyyyy, thank you for your work on leaky-bucket (and this PR)! Updating ferox to work with the newer versions of leaky-bucket has been on my todo list for awhile, but I just haven't been able to get to it. I sincerely appreciate you taking the time to put this together! No need to create the issue, thank you again! |
|
@all-contributors add @udoprog for code |
|
I've put up a pull request to add @udoprog! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking over how leaky-bucket was used prior to 0.11, which introduced self-coordinating rate limiters (no coordinator task running in the background needed) and noticed this project. This bumps leaky-bucket to the latest version (0.12.1), the largest difference is that the default refill interval is changed from 1 second to 100ms so it has to be specified where it previously was not.
I looked over the contributor checklist and everything is OK except there not being a separate issue for this bump. If you want me to create a separate issue please advise.