Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added extensions and status codes into auto filtering decision calculus #869

Merged
merged 6 commits into from
Apr 12, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Apr 11, 2023

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 76.63% and project coverage change: -0.08 ⚠️

Comparison is base (c7498a7) 92.34% compared to head (1ced3b5) 92.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   92.34%   92.26%   -0.08%     
==========================================
  Files          63       63              
  Lines       11443    11499      +56     
==========================================
+ Hits        10567    10610      +43     
- Misses        876      889      +13     
Impacted Files Coverage Δ
src/scanner/ferox_scanner.rs 77.35% <0.00%> (-1.35%) ⬇️
src/heuristics.rs 88.11% <78.77%> (-0.55%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epi052 epi052 merged commit e77c131 into main Apr 12, 2023
12 of 14 checks passed
@epi052 epi052 deleted the auto-filtering-account-for-extensions branch April 12, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant