-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spinners): epic-spinners integration #74
Conversation
<div class="row align-center"> | ||
<div class="col text-center"> | ||
Powered by | ||
<a :href="'http://epic-spinners.epicmax.co/'" target="_blank">Epic Spinners</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing translation
} | ||
}, | ||
computed: { | ||
groups: function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jean-moldovan use es6 syntax here
}, | ||
methods: { | ||
groupItems (items, groupSize) { | ||
var grouped = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jean-moldovan use es6 syntax here (let instead of var)
groupItems (items, groupSize) { | ||
var grouped = [] | ||
|
||
for (var i = 0; i < items.length; i += groupSize) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jean-moldovan use es6 syntax here (let instead of var)
src/i18n/en.json
Outdated
@@ -113,6 +113,9 @@ | |||
"search": "Icon search", | |||
"title": "Icons" | |||
}, | |||
"spinners": { | |||
"title": "Epic Spinners" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change title to 'Spinners'
src/i18n/en.json
Outdated
@@ -128,6 +131,7 @@ | |||
"formWizards": "Form Wizards", | |||
"grid": "Grid", | |||
"icons": "Icons", | |||
"spinners": "Epic Spinners", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change title to 'Spinners'
src/store/modules/menu/ui.js
Outdated
@@ -48,6 +48,14 @@ export default { | |||
} | |||
] | |||
}, | |||
{ | |||
name: 'Epic Spinners', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change title to 'Spinners'
return { | ||
config: { | ||
animation: 1500, | ||
color: '#1ec260', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use store's palette.primary color
data: function () { | ||
return { | ||
config: { | ||
animation: 1500, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of the spinners are way too fast (i think that easy solution is using default animation duration, i will fix flower's spinner default animation duration an publish version 1.0.1)
config: { | ||
animation: 1500, | ||
color: '#1ec260', | ||
size: 50, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
play with the sizes and margins/paddings. Not sure but maybe they'll look better if they are larger?
:color="config.color" | ||
:animation-duration="config.animation" | ||
class="spinner-item"> | ||
</component> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having spinner name displayed (like on icons page) would be nice
@jean-moldovan updated epic-spinners to 1.0.1 (default flower spinner animation duration fixed) |
* fix: bug №41 * fix: open menu item in a new tab * fix: spinners color palette * 1-4, 6-7 * fix: bug №9 (additional tweaks) * fix: bug №17 * fix: bug №21 * fix: bug №22 * fix: bug №23 * fix: bug №24 * fix: bug №15 * fix: "Show All" button alignment * fix: bug №6 * Fix/bugs (#622) * fix: bug №8, bug №10, bug №16, bug №28, bug №36 * revert google map changes * fix: bug #91, 12 * Fix/bugs (#623) * fix: dropdown regression * fix: bug №20 * fix: №89 and №56 * get rid of unnecessary anymore overriding styles * fix: restore default selection for medium-editor * fix: dropdown problem * fix: bug №37 (charts) * fix: bug №90 * fix: bug №93 * fix: bug №94 * fix: bug №95 * Fix/bugs #34 & #37 (#624) * chore: remove old component va-pre-loader * fix: dashboard info block alignment and text wrapping * chore: remove vee-validate (not used) * minor * chore: remove unused deps * chore: update risky deps * fix: VaSelect-mutli chips * Fix/bug #92 (#625) * fix: bugs №46 and №47 * fix: bugs №48 and №49 * fix: bug №52 * fix: bug №84 * Fix/bugs #54, #55, #59, #77, #78 (#626) * fix: bug №71 * fix: bug №87 * Fix/bugs #65, #66, #72, #74, #82, #83 (#627) * Fix/bugs #53, #68 (#628) * fix: bug №42
No description provided.