feat(spinners): customize spinners #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartapant
requested changes
Jan 4, 2018
src/components/ui/icons/Set.vue
Outdated
| @@ -43,12 +48,12 @@ | |||
|
|
|||
| <script> | |||
| import Widget from '../../vuestic-components/vuestic-widget/VuesticWidget' | |||
| import Slider from 'vue-slider-component/src/vue2-slider.vue' | |||
| import VuesticSlider from 'components/vuestic-components/vuestic-slider/VuesticSlider' | |||
There was a problem hiding this comment.
Add slider to vuestic-components-plugin.js and remove useless import
There was a problem hiding this comment.
Ah, right!
Thanks for pointing this out.
| @@ -32,19 +44,25 @@ | |||
| import * as spinners from 'epic-spinners' | |||
| import store from 'vuex-store' | |||
| import VuesticColor from 'components/vuestic-components/vuestic-color/VuesticColor' | |||
| import VuesticSlider from 'components/vuestic-components/vuestic-slider/VuesticSlider' | |||
There was a problem hiding this comment.
Add slider to vuestic-components-plugin.js and remove useless import
| @@ -32,19 +44,25 @@ | |||
| import * as spinners from 'epic-spinners' | |||
| import store from 'vuex-store' | |||
| import VuesticColor from 'components/vuestic-components/vuestic-color/VuesticColor' | |||
There was a problem hiding this comment.
Add color-picker to vuestic-components-plugin.js and remove useless import
| @@ -10,8 +10,10 @@ | |||
| SliderPicker | |||
| }, | |||
| props: { | |||
| value: String, | |||
| required: true | |||
| value: { | |||
There was a problem hiding this comment.
Make color picker beautiful - narrow just like slider, play with dot styles
smartapant
requested changes
Jan 8, 2018
| @@ -62,7 +56,7 @@ | |||
| } | |||
| }, | |||
| selectedColor: store.getters.palette.primary, | |||
| selectedSize: 70 | |||
| selectedSize: 60 | |||
There was a problem hiding this comment.
try using size modifiers for dotSize/pixelsize/etc properties
| ...spinners, | ||
| VuesticColor, | ||
| VuesticSlider | ||
| ...spinners |
There was a problem hiding this comment.
Please, test ALL spinners for dynamic styles change bugs
Closed
|
@smartapant After merging #136, I suppose you can close the PR. |
asvae
added a commit
that referenced
this pull request
Aug 3, 2019
* fix: bug №41 * fix: open menu item in a new tab * fix: spinners color palette * 1-4, 6-7 * fix: bug №9 (additional tweaks) * fix: bug №17 * fix: bug №21 * fix: bug №22 * fix: bug №23 * fix: bug №24 * fix: bug №15 * fix: "Show All" button alignment * fix: bug №6 * Fix/bugs (#622) * fix: bug №8, bug №10, bug №16, bug №28, bug №36 * revert google map changes * fix: bug #91, 12 * Fix/bugs (#623) * fix: dropdown regression * fix: bug №20 * fix: №89 and №56 * get rid of unnecessary anymore overriding styles * fix: restore default selection for medium-editor * fix: dropdown problem * fix: bug №37 (charts) * fix: bug №90 * fix: bug №93 * fix: bug №94 * fix: bug №95 * Fix/bugs #34 & #37 (#624) * chore: remove old component va-pre-loader * fix: dashboard info block alignment and text wrapping * chore: remove vee-validate (not used) * minor * chore: remove unused deps * chore: update risky deps * fix: VaSelect-mutli chips * Fix/bug #92 (#625) * fix: bugs №46 and №47 * fix: bugs №48 and №49 * fix: bug №52 * fix: bug №84 * Fix/bugs #54, #55, #59, #77, #78 (#626) * fix: bug №71 * fix: bug №87 * Fix/bugs #65, #66, #72, #74, #82, #83 (#627) * Fix/bugs #53, #68 (#628) * fix: bug №42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.