Fix#968/users page #970
Fix#968/users page #970
Conversation
src/data/pages/users.ts
Outdated
| notes: 'Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, voluptatum.', | ||
| }, | ||
| { | ||
| id: 7, |
There was a problem hiding this comment.
Let's add some more variety, maybe 10 users on repeat?
Also maybe only nice images, letters are placeholders and we don't have to cover all cases.
There was a problem hiding this comment.
Almost there. Images are great, but when you open the page you see this:
It would be great to see this instead:
Can we maybe remove John Doe, Martin Hoff etc users without images?
There was a problem hiding this comment.
Users without images were used in design, and I'd keep them as an example.
src/data/pages/users.ts
Outdated
| email: 'maksim@epic.com', | ||
| username: 'maksim', | ||
| role: 'admin', | ||
| projects: 1, |
There was a problem hiding this comment.
Let's use project names.
I'm fine without objects, but the way it is right now - I can't say the page is finished. So let's make it look good in this PR, then perhaps move to objects in #984 pr.
There was a problem hiding this comment.
I mean something like the list below, number is not meaningful
"NexaFlow Manager"
"OrbitTrack Suite"
"DataPulse Portal"
"InnoSight Platform"
There was a problem hiding this comment.
We don't have user role specific for project in data, but I can display projects which user a part of.
|
I think some things still need improvement. Coming primarily from user experience perspective. |
|
Move to #985 because we need both projects and users pages at the same time. |
Description
closes #968
Types of changes