You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are two scenarious for the default's slot behavior for the progress bar. It either is located inside the bar, or above it.
The idea is that if it's possible to fit the slot inside the bar, then it should go there, but if the slot won't fit there (as in case with small- and medium-sized bars), it goes above the bar.
Though the issue is that currently the only possible way to locate the slot inside the bar is to set the bar's size property to large. And, as you can see from the screenshot above, when you use some custom size (like 2rem) which is definitely larger than the large size, the slot won't go inside the bar. But ideally it should.
AFAICS, there exist 2 potential solutions for this issue:
Universal, but clutchy and tricky to implement and support: render the bar first, find its actual rendered size and compare it to the slot's rendered size. If the slot's size is smaller than the bar's size, fit the slot inside. Otherwise, put it on top.
The second solution is to provide a new prop, something like boolean slot-inside, which tells wheher it's a good idea for Vuestic to try to fit the slot inside the bar instead of locating it above the progress bar (which is, again, the default and the current behavior).
I personally like the 2nd approach more, though there's a fine line between over-implementing things and providing a lot of freedom for the developers. In other words, such a prop might be an overkill. Please, share your thoughts on the topic.
The text was updated successfully, but these errors were encountered:
Per @RVitaly1978
Currently there are two scenarious for the default's slot behavior for the progress bar. It either is located inside the bar, or above it.
The idea is that if it's possible to fit the slot inside the bar, then it should go there, but if the slot won't fit there (as in case with small- and medium-sized bars), it goes above the bar.
Though the issue is that currently the only possible way to locate the slot inside the bar is to set the bar's size property to
large
. And, as you can see from the screenshot above, when you use some custom size (like 2rem) which is definitely larger than thelarge
size, the slot won't go inside the bar. But ideally it should.AFAICS, there exist 2 potential solutions for this issue:
slot-inside
, which tells wheher it's a good idea for Vuestic to try to fit the slot inside the bar instead of locating it above the progress bar (which is, again, the default and the current behavior).I personally like the 2nd approach more, though there's a fine line between over-implementing things and providing a lot of freedom for the developers. In other words, such a prop might be an overkill. Please, share your thoughts on the topic.
The text was updated successfully, but these errors were encountered: