[#1985] Fix VaProgressBar slot position
#2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVitaly1978
requested review from
Derranion,
m0ksem,
rustem-nasyrov and
aluarius
rustem-nasyrov
approved these changes
Jun 30, 2022
aluarius
approved these changes
Jun 30, 2022
m0ksem
approved these changes
Jun 30, 2022
Comment on lines
77
to
80
| rooStyle: computed(() => ({ | ||
| '--va-progress-bar-background-color': getColor(props.color), | ||
| }) as StyleValue), | ||
|
|
There was a problem hiding this comment.
Just an example of useCSSVariables. You can skip it.
Suggested change
| rooStyle: computed(() => ({ | |
| '--va-progress-bar-background-color': getColor(props.color), | |
| }) as StyleValue), | |
| rooStyle: useCSSVariables('va-progress-bar', () => ({ | |
| 'background-color': getColor(props.color) | |
| })) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #1985
changes:
content-insidepropshow-percentpropTypes of changes