Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaTreeView: display as cursor style maybe better when the mouse moves over the tree node #3465

Closed
mengqiuleo opened this issue Jun 2, 2023 · 7 comments · Fixed by #3473
Closed
Assignees
Labels
d2: easy Recomended mode for new, but mature players feature Something useful to end user good first issue Right issue if you're new to vuestic v3: wish to have This is something user want, but can live without it

Comments

@mengqiuleo
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

VaTreeView:
display as cursor style maybe better when the mouse moves over the tree node.
currently the mouse is the style of the selected text

Describe alternatives you've considered

Additional context

@codeonmoon
Copy link

codeonmoon commented Jun 2, 2023

@mengqiuleo - Can we also add a feature that once user clicks on Label of the nodes it could be expanded and collapsed.
Because as of now, we need to explicitly click on the arrow always.

@m0ksem
Copy link
Collaborator

m0ksem commented Jun 2, 2023

We can have additional prop to set whole tree-node clickable.

clickableArea: { type: String as PropType<'button' | 'node'> }

Then, if the clickable area is a node, the whole node must have cursor: pointer.

@m0ksem m0ksem added feature Something useful to end user good first issue Right issue if you're new to vuestic d2: easy Recomended mode for new, but mature players v3: wish to have This is something user want, but can live without it labels Jun 2, 2023
@mengqiuleo
Copy link
Contributor Author

We can have additional prop to set whole tree-node clickable.

clickableArea: { type: String as PropType<'button' | 'node'> }

Then, if the clickable area is a node, the whole node must have cursor: pointer.

We can add cursor: pointer to va-tree-node-root, then the whole node can have cursor: pointer, because class va-tree-node-root wrap the whole node. And now can removes the arrow style.

@mengqiuleo
Copy link
Contributor Author

@mengqiuleo - Can we also add a feature that once user clicks on Label of the nodes it could be expanded and collapsed. Because as of now, we need to explicitly click on the arrow always.

I'm not sure. I haven't tried it. It might conflict with the selected style. About the selected style in #3456 . Because selecting the parent node also causes the node to collapse, maybe the user just wants to select the parent node.

@mengqiuleo
Copy link
Contributor Author

@m0ksem I want to solve this issue.

@codeonmoon
Copy link

@m0ksem I want to solve this issue.

@mengqiuleo - Is this issue resolved? If yes, by when we can take those changes in our project?

@m0ksem
Copy link
Collaborator

m0ksem commented Jun 13, 2023

@m0ksem I want to solve this issue.

@mengqiuleo - Is this issue resolved? If yes, by when we can take those changes in our project?

HI it is going to be available next release. I think in two weeks. But if you need it urgent, we can make a separate release when this issue will be closed and I'll notify you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d2: easy Recomended mode for new, but mature players feature Something useful to end user good first issue Right issue if you're new to vuestic v3: wish to have This is something user want, but can live without it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants