Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VaTreeView): add cursor style when mouse moves over node #3473

Merged
merged 5 commits into from
Jun 22, 2023
Merged

feat(VaTreeView): add cursor style when mouse moves over node #3473

merged 5 commits into from
Jun 22, 2023

Conversation

mengqiuleo
Copy link
Contributor

@mengqiuleo mengqiuleo commented Jun 6, 2023

close #3465

Description

display as cursor style when the mouse moves over the tree node.
Add cursor: pointer to va-tree-node-root, then the whole node can have cursor: pointer, because class va-tree-node-root wrap the whole node. And now can removes the arrow style.

Markup:

.va-tree-node {
  &-root {
    // other style
    cursor: pointer;
  }
  // other style
}

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review June 20, 2023 01:06
@codeonmoon
Copy link

@m0ksem - Could you please let us know when this will be available for usage

@m0ksem
Copy link
Contributor

m0ksem commented Jun 20, 2023

@m0ksem - Could you please let us know when this will be available for usage

Hi. It will be available in next release after this Friday.

@m0ksem
Copy link
Contributor

m0ksem commented Jun 20, 2023

I change it a little bit, so if expand-by set to node cursor pointer shows on all node. Double check if this is what we needed and let's merge it.

@m0ksem m0ksem merged commit 6a948ec into epicmaxco:develop Jun 22, 2023
1 check passed
@codeonmoon
Copy link

codeonmoon commented Jul 11, 2023

@m0ksem - We want to take this change in our project, could you please guide how to use this?
I assume it is updating the version in package.json file. As of now my project is on 1.6.5. I can see on this link -
https://ui.vuestic.dev/ui-elements/tree-view it is 1.7.1

@m0ksem
Copy link
Contributor

m0ksem commented Jul 11, 2023

@m0ksem - We want to take this change in our project, could you please guide how to use this? I assume it is updating the version in package.json file. As of now my project is on 1.6.5. I can see on this link - ui.vuestic.dev/ui-elements/tree-view it is 1.7.1

@codeonmoon, Yeah. You need to update vuestic-ui in package.json to 1.7.0 or even better to "^1.7.2" and just run npm install (or whatever you use). That should be enought. You might also need to clean node_modules/.vite/deps folder to remove changed files.

@codeonmoon
Copy link

codeonmoon commented Jul 11, 2023

@m0ksem - We want to take this change in our project, could you please guide how to use this? I assume it is updating the version in package.json file. As of now my project is on 1.6.5. I can see on this link - ui.vuestic.dev/ui-elements/tree-view it is 1.7.1

@codeonmoon, Yeah. You need to update vuestic-ui in package.json to 1.7.0 or even better to "^1.7.2" and just run npm install (or whatever you use). That should be enought. You might also need to clean node_modules/.vite/deps folder to remove changed files.

@m0ksem I tried following your instructions here, but I am getting below error now in compile time. The version is
"vuestic-ui": "^1.7.2"
Seems like it is complaining about the import statements. vuestic-ui is being imported as -

import { createVuestic } from "vuestic-ui";
import "vuestic-ui/css";

**Module not found: Error: Default condition should be last one**

Could you please assist.

@m0ksem
Copy link
Contributor

m0ksem commented Jul 11, 2023

@m0ksem - We want to take this change in our project, could you please guide how to use this? I assume it is updating the version in package.json file. As of now my project is on 1.6.5. I can see on this link - ui.vuestic.dev/ui-elements/tree-view it is 1.7.1

@codeonmoon, Yeah. You need to update vuestic-ui in package.json to 1.7.0 or even better to "^1.7.2" and just run npm install (or whatever you use). That should be enought. You might also need to clean node_modules/.vite/deps folder to remove changed files.

@m0ksem I tried following your instructions here, but I am getting below error now in compile time. The version is "vuestic-ui": "^1.7.2" Seems like it is complaining about the import statements. vuestic-ui is being imported as -

import { createVuestic } from "vuestic-ui";
import "vuestic-ui/css";

**Module not found: Error: Default condition should be last one**

Could you please assist.

Can you try 1.7.0? What's your package manager? Maybe create a discussion instead or visit our Discord, so we don't spam to PR author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaTreeView: display as cursor style maybe better when the mouse moves over the tree node
3 participants