feat/sandbox #2306
Merged
feat/sandbox #2306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
changed the title
|
Must be merged after #2294 with fixed conflicts. And fix-import-hell plugin must be rewritten to ts. |
m0ksem
force-pushed
the
fix/nuxt-components-tree-shaking
branch
from
64babff
to
21108b7
Compare
|
@aluarius, I'll need your help to QA my changes here. If you have test nuxt app, check out how build works cuz I don't believe myself. I changed mjs build logic, so this likely must work with vitest without additional effort. (see #2254 (comment)). @asvae I guess you would be interested in |
aluarius
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2273 - nuxt tree-shaking
closes #2280 - rename to sandbox
closes #2307
closes #2255
this pr and #2279 closes #2274 (need to double check)
In addition to sandbox here, I removed CSS import from
.mjsfile, so pure node runners (without CSS loader) like vitest can handle it.I also removed extra
import 'puk.js'which I assume vite thought has side-effects because ofvendor.jsimported.