Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce SEP=: instead of hard-coded : (issues #31) #32

Closed
wants to merge 1 commit into from

Conversation

jeonghanlee
Copy link
Contributor

@jeonghanlee jeonghanlee commented Sep 6, 2018

Pre-discussion at issues #31

@anjohnson

Please review changes in all template files. It doesn't change any others db files from community substitution files. At ESS, I've create the iocAdminSoft-ess.sustitutions in separated repository (e3-iocStats)

This changes give us to use the our own naming conventions strictly.

@MarkRivers

I am sorry about not changing any opi screens, since these changes allow me to follow the ESS naming conventions with the customized ess substitutions file. Once ESS have "bob" screen, I will update it.

@jeonghanlee jeonghanlee mentioned this pull request Sep 9, 2018
@anjohnson
Copy link
Member

I haven't actually tested it but this looks Okay to me, replacing all : separators in the PV names with a macro $(SEP=:) that defaults to : if no value is provided for it. Of course accepting this change affects any other PRs that add new PVs (such as #30) since their names would need modifying to match.

@mark0n
Copy link
Contributor

mark0n commented Apr 18, 2019

I'll update #30 as soon as this one is merged.

@bhill-slac
Copy link
Contributor

Looks like a useful change for those who don't use : in their naming scheme.
I've tested and it works for me.
See https://github.com/bhill-slac/iocStats/tree/preserve-SEP
for a branch which uses $(SEP=:) in iocQueue.db and some other records that are new.
It also modifies the substitutions files to preserve the SEP=: default till dbLoad time
which may allow Jeong to use the default iocAdminSoft.substitutions file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants