Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-server long running command does not give back shell input correctly on fish shell #688

Closed
fredericrous opened this issue Apr 7, 2024 · 3 comments

Comments

@fredericrous
Copy link
Contributor

fredericrous commented Apr 7, 2024

I'm using fish shell on mac, and whenever I close the dev server, the input of the shell is messed up, I cannot see what I am writing, the up command shows ^[[A instead of going back one line in history

basically I'm seeing this

image

the issue goes away when I execute a new command. it can also be a fake command. I generally do ls

note: I'm using hyper terminal but I can reproduce this inside VSCode. I do not seem to get the issue with zsh

I think the issue comes from

stdio: ['ignore', 'inherit', 'inherit'],

input is ignored.. and stays ignored even after a Ctrl+C, until I execute a new command

@fredericrous fredericrous changed the title long running command does not give back shell input correctly on fish shell dev-server long running command does not give back shell input correctly on fish shell Apr 7, 2024
fredericrous added a commit to fredericrous/epic-stack that referenced this issue Apr 7, 2024
fredericrous added a commit to fredericrous/epic-stack that referenced this issue Apr 7, 2024
@kentcdodds
Copy link
Member

I'm not certain this is an issue with the epic stack. Feels like an issue for execa or something wrong with your system. So I'm going to close this issue. Sorry!

@fredericrous
Copy link
Contributor Author

I'm sure all it takes to reproduce the issue is to install fish and try it for yourself. On my end no worries, I fixed the issue. I just wanted to share the solution

@kentcdodds
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants