Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added social networks #7

Closed
wants to merge 7 commits into from
Closed

added social networks #7

wants to merge 7 commits into from

Conversation

yashevde
Copy link

AngelList, Strava, goodreads, Hacker News

@epidrome
Copy link
Owner

  • currently, the suggested way to add social links is to employ the too_social.html file

  • in the next major release, we would like to introduce a more flexible way for managing the social links Social links management #5

@epidrome epidrome closed this Jun 16, 2018
@yashevde
Copy link
Author

I see -- that's an interesting design choice. I just added the extra social links to the main social file, as you can see. Wouldn't it make sense to just list all the available options and then provide them to the user?

For more flexibility, I think the username requirement in the config would have to be changed to the entire URL, due to the differences in formatting for URLs with relation to the username on different sites.

Thoughts?

@epidrome epidrome mentioned this pull request Jun 16, 2018
4 tasks
@epidrome
Copy link
Owner

listing all the available options is probably futile, there will be more social networks in the future, while at the same time even the most popular ones will go extinct, e.g., myspace

i have added your suggestion for full http links instead of username in the respective issue #5, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants