Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change deprecated future::multiprocess -> multicore #289

Merged
merged 6 commits into from Feb 18, 2022
Merged

change deprecated future::multiprocess -> multicore #289

merged 6 commits into from Feb 18, 2022

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Feb 18, 2022

No description provided.

@sbfnk sbfnk requested a review from seabbs February 18, 2022 15:32
@seabbs
Copy link
Contributor

seabbs commented Feb 18, 2022

It probably needs to default to multisession instead even if it is slower as mulitcore not supported on windows or in Rstudio.

ot all operating systems support process forking and thereby not multicore futures. For instance, forking is not supported on Microsoft Windows. Moreover, process forking may break some R environments such as RStudio. Because of this, the future package disables process forking also in such cases. See supportsMulticore() for details. Trying to create multicore futures on non-supported systems or when forking is disabled will result in multicore futures falling back to becoming sequential futures.

@seabbs
Copy link
Contributor

seabbs commented Feb 18, 2022

/document

seabbs
seabbs approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit 75496a3 into master Feb 18, 2022
@seabbs seabbs deleted the deprecate-multiprocess branch February 18, 2022 19:08
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk @seabbs @actions-user
change deprecated future::multiprocess -> multicore (#289)
6ccde3a 
* change deprecated future::multiprocess -> multicore

* use multisession as default

* Update test-setup_future.R

* Update DESCRIPTION

* Update NEWS.md

* Document

Co-authored-by: Sam Abbott <s.e.abbott12@gmail.com>
Co-authored-by: GitHub Actions <actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbfnk @seabbs @actions-user