Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable verbosity for failing chains #433

Merged
merged 10 commits into from Jul 24, 2023
Merged

disable verbosity for failing chains #433

merged 10 commits into from Jul 24, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 21, 2023

Together with #432 this should fix #429

seabbs
seabbs approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

See note about mixing changes in a single PR.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 24, 2023

See note about mixing changes in a single PR.

Thanks for flagging. This was in response to a lint failure but agree would have been better first done in its own PR:
ref: https://github.com/epiforecasts/EpiNow2/actions/runs/5626722416?pr=433

@sbfnk sbfnk merged commit 7bc686b into main Jul 24, 2023
9 checks passed
@sbfnk sbfnk deleted the test-errors branch July 24, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing samplers during tests
2 participants
@sbfnk @seabbs