Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plotting with updated scoringutils #89

Merged
merged 9 commits into from Mar 1, 2023
Merged

fix plotting with updated scoringutils #89

merged 9 commits into from Mar 1, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Mar 1, 2023

Fixes #84 (currently targetting #86 so as to facilitate merging later).

Base automatically changed from seabbs/issue85 to master March 1, 2023 12:49
@seabbs seabbs self-requested a review March 1, 2023 12:53
seabbs
seabbs approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I fixed the remaining depreciation warnings and added a very crude test (similar to the other crude plot tests - all of which ideally would be switched out for a vdiffr or similar more robust approach)

@seabbs seabbs merged commit 40731b4 into master Mar 1, 2023
@seabbs seabbs deleted the plotting-bug branch March 1, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot_compare_timeseries example is broken
2 participants
@sbfnk @seabbs