Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make truncation set across regions #71

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Conversation

seabbs
Copy link
Collaborator

@seabbs seabbs commented Oct 8, 2020

This PR adds support for region-specific truncation after discussion with @kathsherratt about the UK data. At the moment this is set to the current default everywhere (3 days) but this can now be tuned dataset by dataset as new evidence becomes available (like run time analysis etc).

@seabbs seabbs requested review from joeHickson and nikosbosse and removed request for nikosbosse October 8, 2020 14:54
@seabbs
Copy link
Collaborator Author

seabbs commented Oct 14, 2020

@joeHickson happy to merge?

Copy link
Collaborator

@joeHickson joeHickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joeHickson joeHickson merged commit 894c8b3 into master Oct 15, 2020
@joeHickson
Copy link
Collaborator

joeHickson commented Oct 15, 2020

ooo forgot to say needs documentation! Add the param to the SMG.md file.

@joeHickson joeHickson deleted the region-set-truncation branch October 15, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants