Tweak title + basic citation #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiemeakin
requested changes
Jan 19, 2021
| citEntry( | ||
| entry = "Manual", | ||
| title = "NHS trust level Covid-19 data aggregated to a range of spatial scales", | ||
| author = personList(as.person("Sophie Meakin"), as.person("Sam Abbott"), |
There was a problem hiding this comment.
I think we need to acknowledge someone from the NHS, since they shared the raw mapping. @sbfnk ?
There was a problem hiding this comment.
Sounds like a good idea to me.
There was a problem hiding this comment.
merge and resolve when who and what is clear?
There was a problem hiding this comment.
Just need to add authors - but can do that separately, so fine to go ahead and merge
sophiemeakin
approved these changes
Jan 19, 2021
| citEntry( | ||
| entry = "Manual", | ||
| title = "NHS trust level Covid-19 data aggregated to a range of spatial scales", | ||
| author = personList(as.person("Sophie Meakin"), as.person("Sam Abbott"), |
There was a problem hiding this comment.
Just need to add authors - but can do that separately, so fine to go ahead and merge
|
Latest commit fixes NA shadow by using an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates title to more closely match both the present and the future of this package (NHS trust level data aggregated across spatial scales) + adds a basic citation with DOI to allow google scholar tracking etc.
Also adds a code owner flag (this basically marks @sophiemeakin as being the code owner for this repository and anyone who opens a PR will automatically get you flagged to review it). This is probably something we should do more broadly in our repos given we all have so many permissions everyone can commit to master etc when they want to (in this package this should mean only @sophiemeakin can).
(Also makes date filtering skippable for
map_admissions.