Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

covidregionaldata archived on CRAN #472

Open
seabbs opened this issue Jun 27, 2022 · 3 comments
Open

covidregionaldata archived on CRAN #472

seabbs opened this issue Jun 27, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@seabbs
Copy link
Contributor

seabbs commented Jun 27, 2022

https://cran.r-project.org/web/packages/covidregionaldata/index.html
https://cran-archive.r-project.org/web/checks/2022/2022-06-03_check_results_covidregionaldata.html

Due to issues with data being downloaded in the vignettes and readme. This is related to issues with the French data but solving the more general problem of depending on internet resources would be a good idea. I will start looking at this at the end of the week with the plan of a new CRAN release with these issues fixed next week.

@seabbs seabbs added the bug Something isn't working label Jun 27, 2022
@seabbs
Copy link
Contributor Author

seabbs commented Jun 27, 2022

Related to #471 and workaround in #470 by @RichardMN (though perhaps we need to address the root of the problem).

@seabbs
Copy link
Contributor Author

seabbs commented Jun 27, 2022

I'd just suggest we move to having articles vs vignettes: https://usethis.r-lib.org/reference/use_vignette.html

@seabbs
Copy link
Contributor Author

seabbs commented Jun 27, 2022

Another option is local vignette knitting though I think maybe not optimal here? https://ropensci.org/blog/2019/12/08/precompute-vignettes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant