Switch to use Lithuania for slowstart #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids current data problems with France data source
Bisaloo
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Thanks @RichardMN! This looks good.
I'm gonna leave Sam a couple of days to review if he manages to squeeze it in his schedule and otherwise go ahead and merge it.
|
Thanks for reviewing @Bisaloo and in general very happy for authors to merge once reviewed by another author. If wanting me to check out might need a direct ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids current data problems with France data source - fix for #469
Having tried Germany, I've found that the slowstart vignette works with Lithuanian data so (at least until the French data source is fixed) we can use Lithuania in the slowstart vignette.