Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at adding some regional info for Austria #30

Closed
wants to merge 6 commits into from

Conversation

mariabnd
Copy link
Contributor

Here's a rough starting point for Austria (it needs some work)

@mariabnd mariabnd marked this pull request as ready for review July 21, 2020 15:02
@mariabnd
Copy link
Contributor Author

@seabbs This useful to you?

@seabbs
Copy link
Contributor

seabbs commented Jul 21, 2020

Hi Maria,

Yes this looks useful - thanks for adding. Will review in more detail tomorrow.

@mariabnd
Copy link
Contributor Author

@felix-hof might also have a look at it

@kathsherratt
Copy link
Contributor

Hi @mariabnd - thanks for suggesting this.

I have had a first look today and unfortunately had some issues with extracting the data after downloading at the unzip stage. I'm sure this can be resolved easily, so I'll continue to work through this code with @seabbs . After that we will integrate into the overarching get_regional_data() wrapper.

Because of various time pressures, this will likely have to be after the CRAN release over the next few days.

Thanks again for the PR, we will keep in touch with progress.
Kath

@kathsherratt kathsherratt mentioned this pull request Jul 24, 2020
10 tasks
@seabbs
Copy link
Contributor

seabbs commented Aug 7, 2020

Thanks for updating this @felix-hof - I'll review properly on Monday with the aim of merging into master early next week.

Sam

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

This PR has been flagged as stale due to lack of activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants