Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netherlands data #358

Merged
merged 6 commits into from
May 20, 2021
Merged

Add netherlands data #358

merged 6 commits into from
May 20, 2021

Conversation

joseph-palmer
Copy link
Collaborator

This PR adds a class for the Netherlands, with data provided by the RVIM (English: National Institute for Public Health and the Environment). Data includes new cases, deaths and hospital admissions at the province (level 1) and municipality levels (level 2).

The source of the data is a single csv file which has the data at the municipality level and so the class has a clean_level_1() function which aggregates the data at the province level.

@github-actions
Copy link

github-actions bot commented May 20, 2021

👋 Thanks for opening this pull request! Can you please run through the following checklist before requesting review (ticking as complete or if not relevant).

  • Read our contribution guidelines if you have not already done so.
  • If you have altered an existing class please run the tests locally (using devtools::load_all(); devtools::test()) first setting options(testDownload=TRUE, testSource=class-name) and report your findings.
  • If you have added a new data class please run the tests locally for that class (using devtools::load_all(); devtools::test()).
  • Check your code passes our CI checks and review any style and code coverage warnings.
  • Comment with details if unable to get our CI checks to pass or unable to remove all warnings.

Thank you again for the contribution. If making large scale changes consider using our pre-commit hooks (see the contributing guide) to more easily comply with our guidelines.

@joseph-palmer joseph-palmer requested a review from seabbs May 20, 2021 14:56
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice stuff!

@seabbs
Copy link
Contributor

seabbs commented May 20, 2021

Looking at the CRAN logs looks like it doesn't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants