Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stable API URL of Vietnam #427

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Update stable API URL of Vietnam #427

merged 1 commit into from
Sep 30, 2021

Conversation

trilwu
Copy link
Contributor

@trilwu trilwu commented Sep 30, 2021

No description provided.

@RichardMN
Copy link
Collaborator

I know why this is failing and think I can fix it (and test that the data download works) later this morning. Essentially we need to rebuild the available datasets file in data-raw

@RichardMN
Copy link
Collaborator

@ilumitr - I wasn't able to make the patches into your branch but here is what you would need to do to get your branch to pass (I think) the tests:

  • build the package
  • load the package
  • source data-raw/render_available_datasets.R
  • build the package again

This should update the Vietnam documentation and (critically) update the pre-rendered list of available datasets. One of our tests is to check that the pre-rendered list of available datasets matches what the package could render itself, and so this table needs to be rebuilt and updated in the repo.

Alternately, there is now #428 which is built on top of your branch with these steps applied.

@RichardMN RichardMN linked an issue Sep 30, 2021 that may be closed by this pull request
@seabbs seabbs merged commit 1d6c024 into epiforecasts:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP error 502 when downloading Vietnam's json data
3 participants