Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 223 issue with add_coverage #234

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented May 30, 2022

When by is not null we saw an issue with add_coverage highlighted in #223. This appears to be caused by an issue in the data.table code. Dropping into debug changing the call to the mean function to be explict (i.e base::mean) fixes the issue on my system. If this also causes no reversions on CI etc I'd suggest merging as aa bug fix for bleeding edge users. I can't identify any changes in data.table that would lead to this change so still hypothetical that this was the system level difference.

@seabbs seabbs requested a review from nikosbosse May 30, 2022 10:19
@seabbs seabbs linked an issue May 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #234 (ba57306) into master (b0cee59) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ba57306 differs from pull request most recent head 4952d7e. Consider uploading reports for the commit 4952d7e to get more accurate results

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          22       22           
  Lines        1355     1355           
=======================================
  Hits         1236     1236           
  Misses        119      119           
Impacted Files Coverage Δ
R/summarise_scores.R 89.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0cee59...4952d7e. Read the comment docs.

@seabbs seabbs requested a review from Bisaloo May 30, 2022 10:31
@nikosbosse
Copy link
Contributor

Very confusing... Thanks for looking into this!
I'll just merge it and hope that solves the issue...

@nikosbosse nikosbosse merged commit 84c6ed0 into master May 30, 2022
@nikosbosse nikosbosse deleted the bug-223-data.table-dev branch May 30, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vignette code failing with error (add_coverage)
2 participants