Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make forecast unit clearer #264

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Make forecast unit clearer #264

merged 4 commits into from
Jan 18, 2023

Conversation

nikosbosse
Copy link
Contributor

  • add explanations in the documentation to make it clearer what the unit of a single forecast is and how it is inferred

@nikosbosse
Copy link
Contributor Author

What we could potentially add to this PR or a new PR is an argument forecast unit that can be passed to ... such that this can be controlled actively.

@nikosbosse nikosbosse linked an issue Jan 18, 2023 that may be closed by this pull request
In Summaries scores, relative skill scores change when there is another unrelated column added #255
Closed
@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #264 (e1ca663) into master (58d93db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          21       21           
  Lines        1284     1284           
=======================================
  Hits         1166     1166           
  Misses        118      118
Impacted Files Coverage Δ
R/pairwise-comparisons.R 87.30% <ø> (ø)
R/score.R 100.00% <ø> (ø)
R/summarise_scores.R 89.74% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

seabbs
seabbs approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice. Need to add this to the news.

@nikosbosse nikosbosse merged commit 37779f6 into master Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In Summaries scores, relative skill scores change when there is another unrelated column added
2 participants
@nikosbosse @seabbs