New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting overhaul #284
Merged
Merged
Linting overhaul #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
force-pushed
the
seabbs/lint-only-changed
branch
from
April 19, 2023 11:18
51fed2c
to
fd64f46
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 90.23% 89.48% -0.75%
==========================================
Files 22 22
Lines 1331 1351 +20
==========================================
+ Hits 1201 1209 +8
- Misses 130 142 +12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
seabbs
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
package improvement
labels
Apr 19, 2023
Amazing, thanks a lot! |
nikosbosse
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
package improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inspired by @Bisaloo recent PR to the
{epinowcast}
package.It changes the linting GitHub Action to only trigger on changed files and also updates
.lintr
to make use of a wider range of linters.As this then introduces a large number of linting flags it then resolves all of these.
In testing this PR I noticed that there were some issues with the snapshot tests for
score()
andsummarise_score()
. I have resolved these.