Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix quantile/sample mixup in vignette #308

Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix quantile/sample mixup in vignette #308

merged 3 commits into from
Jul 25, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 25, 2023

Fixes #306.

This also renames the introductory vignette so it appears as a separate navbar item "Get Started". I think this is preferable but happy to revert if people disagree.

I have fixed linting issues where changing files has caused them to be flagged.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #308 (08277bc) into main (b11b970) will not change coverage.
The diff coverage is n/a.

❗ Current head 08277bc differs from pull request most recent head e30db05. Consider uploading reports for the commit e30db05 to get more accurate results

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          22       22           
  Lines        1377     1377           
=======================================
  Hits         1235     1235           
  Misses        142      142           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This will make it appear as a separate "Get Started" item in the pkgdown
navbar.
Copy link
Contributor

@nikosbosse nikosbosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@nikosbosse nikosbosse merged commit a493b4c into main Jul 25, 2023
9 checks passed
@nikosbosse nikosbosse deleted the intro-vignette branch July 25, 2023 09:16
@seabbs
Copy link
Contributor

seabbs commented Jul 25, 2023

Flagging this PR was missing a news + dev version update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos in vignette
3 participants