Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 428 fix metrics table #489

Merged
merged 5 commits into from
Nov 25, 2023
Merged

Issue 428 fix metrics table #489

merged 5 commits into from
Nov 25, 2023

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Nov 20, 2023

Fixes #428

As discussed in #428, there were a few duplicate table entries in the metrics table. I initially thought these were caused by the way that the data was constructed, but it turns out the solution was just to call unique() on the table before using it in the vignette (because other columns like the name of the function, which make the table non-unique, were removed and are not shown in the vignette)

There were additional issues with the table raised by JSS reviewers. These concerned e.g. the orientation of the log score (and making it clear that we're using the negative log likelihood). In addition, I corrected a few spelling and grammatical errors and changed "true value" to "observed value".

We will eventually have to rework this table a bit (see #415 (which is mostly a stub issue at this point)), but I think it makes sense to fix errors now and spend time later to think about how to update the table.

This was referenced Nov 22, 2023
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Why not do this in a single pipe? This PR has no associated news update.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e849d60) 90.87% compared to head (ce29ee5) 90.91%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   90.87%   90.91%   +0.03%     
==========================================
  Files          22       23       +1     
  Lines        1392     1398       +6     
==========================================
+ Hits         1265     1271       +6     
  Misses        127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse
Copy link
Contributor Author

Added a news item. There are two pipes now because the previous single pipe had a call to nrow(data), but the numbers of rows for the data was changed throughout the pipe by the call to unique(). I guess %>% would have allowed a call to nrow(.)? But not sure there is a good way to replicate that with |>

@nikosbosse nikosbosse merged commit 4c3bcea into main Nov 25, 2023
11 checks passed
@nikosbosse nikosbosse deleted the issue-428-fix-metrics-table branch November 25, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Fix duplicate rows in metric-details table
2 participants