Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of new go 1.20 cover feature #2334

Merged
merged 1 commit into from
May 26, 2023
Merged

Implementation of new go 1.20 cover feature #2334

merged 1 commit into from
May 26, 2023

Conversation

enrichman
Copy link
Member

@enrichman enrichman commented May 26, 2023 •
edited
Loading

Ref: #2306

andreas-kupries
andreas-kupries approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@andreas-kupries andreas-kupries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enrichman enrichman changed the title implementation of new go 1.20 cover feature Implementation of new go 1.20 cover feature May 26, 2023
@enrichman enrichman mentioned this pull request May 26, 2023
Open
@enrichman enrichman self-assigned this May 26, 2023
@enrichman enrichman added the kind/quality Tech Debt / Cleanup label May 26, 2023
@enrichman enrichman added this to the Outside release-cycle milestone May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.10 🎉

Comparison is base (a4c6128) 63.80% compared to head (87eeee1) 64.91%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2334      +/-   ##
==========================================
+ Coverage   63.80%   64.91%   +1.10%     
==========================================
  Files         180      180              
  Lines       15361    15361              
==========================================
+ Hits         9801     9971     +170     
+ Misses       4371     4225     -146     
+ Partials     1189     1165      -24
Flag Coverage Δ
acceptance-api 47.81% <100.00%> (+1.02%) ⬆️
acceptance-apps 38.16% <100.00%> (+0.76%) ⬆️
acceptance-cli 61.44% <100.00%> (+1.24%) ⬆️
unittests 8.52% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/cli/server.go 88.02% <100.00%> (ø)

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@enrichman enrichman marked this pull request as ready for review May 26, 2023 08:37
@enrichman enrichman requested a review from a team as a code owner May 26, 2023 08:37
@enrichman enrichman merged commit 0fa5649 into main May 26, 2023
@enrichman enrichman deleted the implement-go-cover-feature branch May 26, 2023 10:58
@enrichman enrichman added the status/skip-changelog Used with release-drafter to not display PR in a release changelog label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-kupries andreas-kupries andreas-kupries approved these changes

Assignees

@enrichman enrichman

Labels
kind/quality Tech Debt / Cleanup status/skip-changelog Used with release-drafter to not display PR in a release changelog
Projects
Epinio planning
Archived in project
Milestone
Outside release-cycle
Development

Successfully merging this pull request may close these issues.
2 participants
@enrichman @andreas-kupries