Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing failure on service port-forward with non-existing service #2486

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

andreas-kupries
Copy link
Contributor

@andreas-kupries andreas-kupries commented Jul 27, 2023

fix #2425

@andreas-kupries andreas-kupries added the kind/bug Something isn't working label Jul 27, 2023
@andreas-kupries andreas-kupries added this to the v1.10.0 milestone Jul 27, 2023
@andreas-kupries andreas-kupries self-assigned this Jul 27, 2023
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.38% ⚠️

Comparison is base (b075df2) 67.69% compared to head (9e9680b) 67.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
- Coverage   67.69%   67.32%   -0.38%     
==========================================
  Files         184      184              
  Lines       15303    15303              
==========================================
- Hits        10360    10303      -57     
- Misses       3918     3961      +43     
- Partials     1025     1039      +14     
Flag Coverage Δ
acceptance-api 49.11% <0.00%> (-0.26%) ⬇️
acceptance-apps 38.52% <0.00%> (ø)
acceptance-cli 63.58% <100.00%> (-0.55%) ⬇️
unittests 13.26% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/cli/usercmd/service.go 83.33% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-kupries andreas-kupries marked this pull request as ready for review July 27, 2023 14:12
@andreas-kupries andreas-kupries requested a review from a team as a code owner July 27, 2023 14:12
Copy link

@giubacc giubacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andreas-kupries andreas-kupries merged commit ca0372f into main Jul 27, 2023
18 checks passed
@andreas-kupries andreas-kupries deleted the 2425-check-service-port-forward branch July 27, 2023 14:51
@enrichman enrichman changed the title Fixed failure to abort port-forwarding early when targeted service does not exist Fixed missing failure on service port-forward with non-existing service Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

epinio service port-forward should fail if service does not exist
2 participants