Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added branch and revision fields to ImportGit API #2487

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

enrichman
Copy link
Member

This PR adds the revision field to the ImportGit API response.

type ImportGitResponse struct {
	BlobUID  string `json:"blobuid,omitempty"`
	Branch   string `json:"branch,omitempty"`
	Revision string `json:"revision,omitempty"`
}

During the import we are going to resolve the exact revision, if not provided. This revision can be then used to fill the Origin.Git.Revision with the right value.

Fix: #2491

@enrichman enrichman added the kind/enhancement New feature or request label Jul 27, 2023
@enrichman enrichman added this to the v1.10.0 milestone Jul 27, 2023
@enrichman enrichman self-assigned this Jul 27, 2023
@enrichman enrichman requested a review from a team as a code owner July 27, 2023 15:00
@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 84.37% and project coverage change: -0.32% ⚠️

Comparison is base (b075df2) 67.69% compared to head (18313bc) 67.38%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   67.69%   67.38%   -0.32%     
==========================================
  Files         184      184              
  Lines       15303    15325      +22     
==========================================
- Hits        10360    10326      -34     
- Misses       3918     3962      +44     
- Partials     1025     1037      +12     
Flag Coverage Δ
acceptance-api 49.25% <81.25%> (-0.12%) ⬇️
acceptance-apps 38.35% <0.00%> (-0.18%) ⬇️
acceptance-cli 63.55% <50.00%> (-0.59%) ⬇️
unittests 13.23% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/api/core/v1/models/models.go 100.00% <ø> (ø)
internal/api/v1/application/importgit.go 69.08% <83.87%> (+7.79%) ⬆️
internal/cli/usercmd/push.go 78.09% <100.00%> (-2.40%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrichman enrichman force-pushed the 263-make-the-commitrevision-selection-optional branch from c532256 to 18313bc Compare July 28, 2023 13:29
@enrichman enrichman merged commit b5ec885 into main Jul 28, 2023
18 checks passed
@enrichman enrichman deleted the 263-make-the-commitrevision-selection-optional branch July 28, 2023 15:26
@enrichman enrichman changed the title Add branch and revision to ImportGit API Added branch and revision fields to ImportGit API Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add missing branch and revision info when pushing from CLI
2 participants