Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to run without cert-manager #2681

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

andreas-kupries
Copy link
Contributor

Close #2476
Import of chart PR epinio/helm-charts#509

Experimental x3

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87db6b4) 66.32% compared to head (c4b664b) 66.20%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2681      +/-   ##
==========================================
- Coverage   66.32%   66.20%   -0.12%     
==========================================
  Files         210      210              
  Lines       18486    18486              
==========================================
- Hits        12261    12239      -22     
- Misses       5112     5131      +19     
- Partials     1113     1116       +3     
Flag Coverage Δ
acceptance-api 46.27% <ø> (-0.07%) ⬇️
acceptance-apps 36.26% <ø> (ø)
acceptance-cli 62.15% <ø> (-0.23%) ⬇️
unittests 14.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreas-kupries andreas-kupries marked this pull request as ready for review November 14, 2023 09:40
@andreas-kupries andreas-kupries requested a review from a team as a code owner November 14, 2023 09:40
@andreas-kupries andreas-kupries merged commit 938b2cc into main Nov 14, 2023
17 checks passed
@andreas-kupries andreas-kupries deleted the 2476-no-cert-manager branch November 14, 2023 10:20
@enrichman enrichman added kind/enhancement New feature or request and removed kind/dependencies labels Dec 1, 2023
@enrichman enrichman changed the title importing experimental excision of cert-manager Added ability to run without cert-manager Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm-chart Related to the Epinio Helm Chart kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Have the possibility to not use certmanager
3 participants